Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

css-rule .axis line is missing specifier .dc-chart #1007

Closed
arjanvanderleden opened this issue Sep 16, 2015 · 2 comments
Closed

css-rule .axis line is missing specifier .dc-chart #1007

arjanvanderleden opened this issue Sep 16, 2015 · 2 comments
Labels
Milestone

Comments

@arjanvanderleden
Copy link

In dc.css (line 68) there is a double rule for .axis path and .axis line within a .dc-chart
the rule for .axis line is missing the parent specifier .dc-chart

https://github.com/dc-js/dc.js/blob/develop/dc.css#L68

That can (and does) conflict with other parties css rules

@gordonwoodhull
Copy link
Contributor

Thanks @arjanvanderleden, the precedence of the css selector , operator is a frequent stumbling block.

It looks like this one is also wrong, although less harmful:
https://github.com/dc-js/dc.js/blob/develop/dc.css#L256

Putting a line break after the , would make the precedence clearer, as done here:
https://github.com/dc-js/dc.js/blob/develop/dc.css#L275-L276

@gordonwoodhull gordonwoodhull added this to the v2.0 milestone Sep 16, 2015
@gordonwoodhull
Copy link
Contributor

fixed by #1011

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants