New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

dc.baseMixin replaceFilter does not return chart instance #1275

Closed

yreifschneider opened this issue Feb 8, 2017 · 1 comment

yreifschneider commented Feb 8, 2017

Documentation states, that a call to replaceFilter return the chart instance and therefor can be chained. But the code is missing a return statement.

_chart.replaceFilter = function (filter) {
    _filters = _resetFilterHandler(_filters);
    _chart.filter(filter); // missing return here
};

Contributor

gordonwoodhull commented Feb 8, 2017

Thanks @skidr0w for the report!

I don't know why I haven't fixed this yet - guess it slipped my mind. It's a duplicate of #1227.

gordonwoodhull closed this as completed

# for free to join this conversation on GitHub. Already have an account? # to comment