Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Possible issue in dc.filters.RangedTwoDimensionalFilter - Math.max / Math.min #1432

Closed
kum-deepak opened this issue May 7, 2018 · 2 comments

Comments

@kum-deepak
Copy link
Collaborator

There may be a possible issue in dc.filters.RangedTwoDimensionalFilter as it uses Math.max and Math.min. These functions do not go well if parameters are dates.

I will investigate further, probably write test case(s) and if indeed it is a problem, I will submit a PR.

I have also searched the complete src folder, could not find any other potentially dangerous usage of Math.max / Math.min.

@kum-deepak
Copy link
Collaborator Author

It is not an issue as proved by additional test cases added by #1437.

@gordonwoodhull
Copy link
Contributor

I think less-than and greater-than are okay for dates. It's only === that causes trouble.

Anyway it's great that we test this now!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants