Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

dataCount takes a crossfilter as its dimension #1499

Closed
gordonwoodhull opened this issue Nov 16, 2018 · 4 comments
Closed

dataCount takes a crossfilter as its dimension #1499

gordonwoodhull opened this issue Nov 16, 2018 · 4 comments
Labels

Comments

@gordonwoodhull
Copy link
Contributor

Continuing the tradition of misnaming methods (#855), you need to pass a crossfilter object as the dimension to the dataCount widget.

C'mon, really? Why? Are we deliberately trying to trip people up?

@kum-deepak
Copy link
Collaborator

I did get tripped over it during my effort to split crossfilter into an interface (as part of my effort to create remote data providers).

@gordonwoodhull
Copy link
Contributor Author

gordonwoodhull commented Nov 30, 2018

Hi @kum-deepak! I started a library for providing what's needed by dc.js of the crossfilter interface here:

https://github.com/att/xfilter

So far it supports Nanocubes and a simple restful server as backends.

It could be improved a lot but maybe it will provide you some ideas.

@kum-deepak
Copy link
Collaborator

Actually my code would have reached very similar to this project. Many thanks!

Quite timely for me.

@gordonwoodhull
Copy link
Contributor Author

gordonwoodhull commented Feb 25, 2019

A way forward for these places where a property name is reused in an incompatible way:

  1. Change mandatoryAttributes for these classes so that the problematic properties are not required.
  2. Implement a new property with a more appropriate name. (I guess crossfilter here, and perhaps also groupAll instead of group... neither of those is entirely satisfactory but they would be more clear.)
  3. Deprecate the existing property with a warning that the property name is misleading, and forward the setter to the new property.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants