the way we save the stack in errors defeats the stack

[gordonwoodhull]

I did this in bbee2c4:

dc.js/src/errors.js

Line 11 in 8108281

this.stack = (new Error()).stack;

I presume it helped in some old browser, but now it replaces the usual stack with a stringy stack that doesn't work well in debuggers.

[gordonwoodhull]

I'm not even seeing an error in the browser console in Firefox, so I wonder if throwing objects derived from Error is a good idea.

[gordonwoodhull]

There are no try-catch blocks in the code at all, so for better or worse, removing the classes would only potentially affect clients of the library.

A brief search across repos on github did not reveal anyone using InvalidStateException but I guess the rest should be searched too... if that's the right approach. Would be preferable to fix the current derivation.

[kum-deepak]

It has already been updated. This issue can be closed.

[gordonwoodhull]

fixed in #1548