Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(header): Avoid need to match certain format for urls #163

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

duranmla
Copy link
Contributor

What:
Avoid url formats to break functionality of header

Why:
Otherwise we need to update all env for all sites just for one slash

How:
Normalise the urls depending on the usage within the header which makes the experience more robust when integrate it

instead normalise urls within the component to avoid '/' break functionality
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #163 (50ce070) into development (3ae291f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #163   +/-   ##
============================================
  Coverage        90.40%   90.40%           
============================================
  Files               23       23           
  Lines              396      396           
  Branches            95       95           
============================================
  Hits               358      358           
  Misses              37       37           
  Partials             1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ae291f...50ce070. Read the comment docs.

@duranmla duranmla merged commit 8ab6467 into development Jun 18, 2021
@duranmla duranmla deleted the ad/normalise-links branch June 18, 2021 16:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant