TypeError: must be str, not bytes in ppt_parser.decompressor.decompress

[jloehel]

oletools/oletools/ppt_parser.py

Line 1618 in d03c868

decomp = ''

I guess this should be:

decomp = b''

Traceback:

Traceback (most recent call last):
...
  File "/home/jloehel/projects/github.com/**/**/.venv/lib64/python3.6/site-packages/oletools/olevba.py", line 2704, in __init__
    self.open_ppt()
  File "/home/jloehel/projects/github.com/**/**/.venv/lib64/python3.6/site-packages/oletools/olevba.py", line 3018, in open_ppt
    for vba_data in ppt.iter_vba_data():
  File "/home/jloehel/projects/github.com/**/**/.venv/lib64/python3.6/site-packages/oletools/ppt_parser.py", line 1147, in wrapped
    for result in func(self, self._open_main_stream, *args, **kwargs):
  File "/home/jloehel/projects/github.com/**/**/.venv/lib64/python3.6/site-packages/oletools/ppt_parser.py", line 1604, in iter_vba_data
    yield self.decompress_vba_storage(storage)
  File "/home/jloehel/projects/github.com/**/**/.venv/lib64/python3.6/site-packages/oletools/ppt_parser.py", line 1114, in wrapped
    return func(self, self._open_main_stream, *args, **kwargs)
  File "/home/jloehel/projects/github.com/**/**/.venv/lib64/python3.6/site-packages/oletools/ppt_parser.py", line 1555, in decompress_vba_storage
    iterative_decompress(stream, storage.data_size)
  File "/home/jloehel/projects/github.com/**/**/.venv/lib64/python3.6/site-packages/oletools/ppt_parser.py", line 1624, in iterative_decompress
    decomp += decompressor.decompress(stream.read(n_new))
TypeError: must be str, not bytes

[jloehel]

This is the same issue: #177 There is also already a PR open for this: #450. @decalage2 Any chance to get this merged soon? :-)

[decalage2]

I just merged PR #450 and now it works on the few PPT samples I tested.
@jloehel could you please confirm it solves the issue on your side?

[jloehel]

I just merged PR #450 and now it works on the few PPT samples I tested.
@jloehel could you please confirm it solves the issue on your side?

Thanks for the quick response. It works fine now. :-) I can parse now the most of the samples. I experience more issues with PPT samples but I will report them in separated issues.