Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[cms] Invoice details & edit pages endless loading #2204

Closed
amass01 opened this issue Nov 18, 2020 · 4 comments · Fixed by #2240
Closed

[cms] Invoice details & edit pages endless loading #2204

amass01 opened this issue Nov 18, 2020 · 4 comments · Fixed by #2240
Assignees

Comments

@amass01
Copy link
Member

amass01 commented Nov 18, 2020

When having an invoice with wrong proposal token which causes a 400 error when displaying invoice details, the gui keeps loading forever!

@amass01
Copy link
Member Author

amass01 commented Nov 18, 2020

It would be great if we add a validation in Invoice form to avoid it in the future, apparently one of my description fields was pasted as proposal token, this why the invoice has an item with invalid string as proposal token.

@xaur
Copy link

xaur commented Dec 14, 2020

Closing duplicate #2249, but I will post here its summary.

It looks like we have four issues here:

  • first of all, the backend should not accept malformed proposal token value (create an issue if necessary)
  • the UI should not crash on 400 from the backend and show something
  • the UI should do a basic sanity check and not allow strings that don't look like proposal tokens
  • the backend needs a more descriptive error message to show on the UI when it does a batch request with malformed tokens

@amass01
Copy link
Member Author

amass01 commented Dec 15, 2020

Will open a different issue for the validation.

@xaur
Copy link

xaur commented Jan 5, 2021

Backend validation: decred/politeia#1344

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants