Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

doc, Window-based change point detection - description of predict function #59

Closed
gjaeger opened this issue Aug 20, 2020 · 2 comments · Fixed by #60
Closed

doc, Window-based change point detection - description of predict function #59

gjaeger opened this issue Aug 20, 2020 · 2 comments · Fixed by #60

Comments

@gjaeger
Copy link
Contributor

gjaeger commented Aug 20, 2020

In the section "window-based change point detection" I noticed the following in window.py line 248:

    def predict(self, n_bkps=None, pen=None, epsilon=None):
        """Return the optimal breakpoints.
        Must be called after the fit method. The breakpoints are associated with the signal passed
        to fit().
        The stopping rule depends on the parameter passed to the function.
        Args:
            n_bkps (int): number of breakpoints to find before stopping.
            penalty (float): penalty value (>0)
            penalty (float): penalty value
        Returns:
            list: sorted list of breakpoints
        """

Should the arguments not be described as follows?

    def predict(self, n_bkps=None, pen=None, epsilon=None):
        """Return the optimal breakpoints.
        Must be called after the fit method. The breakpoints are associated with the signal passed
        to fit().
        The stopping rule depends on the parameter passed to the function.
        Args:
            n_bkps (int): number of breakpoints to find before stopping.
            pen (float): penalty value (>0)
            epsilon (float): reconstruction budget (>0)
        Returns:
            list: sorted list of breakpoints
        """
@deepcharles
Copy link
Owner

Yes you are right.
Would you mind making a pull request?
Many thanks

@deepcharles
Copy link
Owner

The online documentation will be updated on the next release. Thanks again.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants