Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Migrate scripted tests to jest #52

Open
Racer159 opened this issue Nov 22, 2024 · 0 comments
Open

Migrate scripted tests to jest #52

Racer159 opened this issue Nov 22, 2024 · 0 comments
Labels
tech-debt 💳 Debt that the team has charged and needs to repay

Comments

@Racer159
Copy link
Contributor

Describe what should be investigated or refactored

We should refactor the tests introduced in #50 into jest tests instead to align with the patterns of other repositories (like GitLab Runner)

Links to any relevant code

https://github.com/defenseunicorns/uds-package-valkey/blob/f68ba6181ae4413b5b5a660ef86b990aa8721f41/tests/watch-jobs.sh

Additional context

This was added as a script to speed delivery of the feature - the test could also be refactored to send traffic more directly through a replicated node so that it doesn't have to make as many requests to hit a replicated node (which may cause flakes).

@Racer159 Racer159 added the tech-debt 💳 Debt that the team has charged and needs to repay label Nov 22, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
tech-debt 💳 Debt that the team has charged and needs to repay
Projects
None yet
Development

No branches or pull requests

1 participant