Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

skip checking any assertions if nothing has been claimed #184

Open
hawkrives opened this issue Dec 10, 2020 · 1 comment
Open

skip checking any assertions if nothing has been claimed #184

hawkrives opened this issue Dec 10, 2020 · 1 comment
Labels
bug Something isn't working question Further information is requested

Comments

@hawkrives
Copy link
Contributor

This is not a performance optimization; instead, this ensures that less-than assertions don't turn green when there's nothing for them to assert against.

For example:

Requirement: Performance Studies [needs-more-items]
    [needs-more-items] Given all 0 courses matching subject == MUSPF and credits == 1.0 and level ∈ [100, 200] and name == '' and institution == STOLAF
        There must be:
          - count(terms) ≥ 6 [empty]
          - count(terms) where level == 100 ≤ 4 [done]

when in fact we would expect

Requirement: Performance Studies [needs-more-items]
    [needs-more-items] Given all 0 courses matching subject == MUSPF and credits == 1.0 and level ∈ [100, 200] and name == '' and institution == STOLAF
        There must be:
          - count(terms) ≥ 6 [empty]
          - count(terms) where level == 100 ≤ 4 [empty]

since there were no courses matching the filter.

@hawkrives hawkrives added bug Something isn't working question Further information is requested labels Dec 10, 2020
@hawkrives
Copy link
Contributor Author

I tagged as question because I don't remember if I've done this or not, yet.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant