Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Errors in Yelp notebook #10

Open
isoboroff opened this issue Mar 27, 2019 · 1 comment
Open

Errors in Yelp notebook #10

isoboroff opened this issue Mar 27, 2019 · 1 comment

Comments

@isoboroff
Copy link

In the Chapter 3 notebook on preprocessing the Yelp data (LITE), there is duplicated code in blocks 4, 9, and 10. I don't the book in front of me right now, so maybe there's a reason why you do everything two or three times, but just reading the notebook I don't see why. If I'm wrong some comments would be good here.

@aoifecahill
Copy link

Specifically, in block 10, the code

         train_bar.n = 0
         val_bar.n = 0
         epoch_bar.update()

seems to be duplicated which leads to the epoch bar incorrectly updating twice for each epoch.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants