Skip to content

Remove preferences dependency from USourceGen #167

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
delphidabbler opened this issue Apr 30, 2025 · 0 comments
Closed

Remove preferences dependency from USourceGen #167

delphidabbler opened this issue Apr 30, 2025 · 0 comments
Assignees
@delphidabbler
Labels
completed Work has been completed on this issue and changes have been committed to `develop` branch.. refactoring This issue requires refactoring only, not a change in functionality

Comments

@delphidabbler
Copy link
Owner

The only call to Preferences in USourceGen is in TSourceGen.UnitAsString, which gets details of warning compiler directives. Despite TSourceGen.UnitAsString already having numerous parameters, it would be better to pass warnings to this method as a parameter and then remove UPreferences from the USourceGen's unit clause.
@delphidabbler delphidabbler self-assigned this Apr 30, 2025
@delphidabbler delphidabbler added accepted Accepted for implementation / fixing refactoring This issue requires refactoring only, not a change in functionality labels Apr 30, 2025
@github-project-automation github-project-automation bot moved this to Considering in CodeSnip Apr 30, 2025
@delphidabbler delphidabbler moved this from Considering to Accepted in CodeSnip Apr 30, 2025
@delphidabbler delphidabbler added completed Work has been completed on this issue and changes have been committed to `develop` branch.. and removed accepted Accepted for implementation / fixing labels Apr 30, 2025
@delphidabbler delphidabbler moved this from Accepted to Considering in CodeSnip Apr 30, 2025
@delphidabbler delphidabbler removed this from CodeSnip May 2, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@delphidabbler delphidabbler

Labels
completed Work has been completed on this issue and changes have been committed to `develop` branch.. refactoring This issue requires refactoring only, not a change in functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@delphidabbler