Add a --limit option to read-table-multi-threaded #297
Conversation
|
|
||
| /// Limit to printing only LIMIT rows. | ||
| #[arg(short, long)] | ||
| limit: Option<usize>, |
There was a problem hiding this comment.
out of curiosity why usize instead of u64?
There was a problem hiding this comment.
oh i suppose slice/take/etc for iterators take usize. interesting though since i feel like this communicates length but i always associate usize with indexes
There was a problem hiding this comment.
yeah. I had it as a u32, but then I'd just have to cast it below, so I figured make it a usize here
| return Ok((Box::new(store), path)); | ||
| Ok((Box::new(store), path)) |
There was a problem hiding this comment.
do we have linting in ci to make committing this impossible in the first place?
There was a problem hiding this comment.
we do, we run rustfmt and clippy. surprised clippy didn't catch this..?
There was a problem hiding this comment.
Thanks for reminding me! It's because our CI didn't run clippy with --all-features so it wasn't checking this (it's behind the cloud feature.
I've updated the workflow file now to run with --all-features. Hopefully that's uncontroversial :)
Arrow printing is actually really slow, so for a big table it's useful to be able to just print a few rows and the total count, for testing, or to get a sense of how fast kernel