Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

enhance error reporting for unrecognized table features #703

Open
sebastiantia opened this issue Feb 19, 2025 · 0 comments
Open

enhance error reporting for unrecognized table features #703

sebastiantia opened this issue Feb 19, 2025 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sebastiantia
Copy link
Collaborator

sebastiantia commented Feb 19, 2025

Please describe why this is necessary.

Currently, the protocol parser fails on the first unrecognized table feature it encounters. This behavior means that if a protocol contains multiple unrecognized features (for example, newerDeltaFeature1 and newerDeltaFeature2), only one error is reported and the user remains unaware of the others. This issue proposes to modify the implementation so that parsing continues to collect all unrecognized features and then reports them collectively in a single error message.

Describe the functionality you are proposing.

There exists the UnrecognizedReaderFeature(String) and UnrecognizedWriterFeature(String) features which are currently only used in tests to act as unsupported table features.

Leverage these features to collect all unrecognized table features during protocol parsing and then report them in a single error message, for example:
ERROR: Found unsupported reader features: newerDeltaFeature1, newerDeltaFeature2

Make sure to update current tests:
test_roundtrip_writer_features & test_roundtrip_reader_features

Additional context

No response

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant