From eb33558b5bd1cf08281d2e0d794318c5c55ae4b0 Mon Sep 17 00:00:00 2001 From: Dhruv Arya Date: Fri, 29 Sep 2023 12:38:36 -0700 Subject: [PATCH] [Spark] Update V2 Checkpoint feature name to indicate feature completeness Now that all V2 Checkpoints are feature complete as per the Delta spec, this updates the table feature name to indicate that it is ready for use. Closes delta-io/delta#2124 GitOrigin-RevId: 8e45e735ef3e1ce071082e1c0833e9157f1c81b5 --- .../main/scala/org/apache/spark/sql/delta/DeltaConfig.scala | 4 +--- .../main/scala/org/apache/spark/sql/delta/TableFeature.scala | 5 +---- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/spark/src/main/scala/org/apache/spark/sql/delta/DeltaConfig.scala b/spark/src/main/scala/org/apache/spark/sql/delta/DeltaConfig.scala index a60f45f80cc..f4904a5572e 100644 --- a/spark/src/main/scala/org/apache/spark/sql/delta/DeltaConfig.scala +++ b/spark/src/main/scala/org/apache/spark/sql/delta/DeltaConfig.scala @@ -637,11 +637,9 @@ trait DeltaConfigsBase extends DeltaLogging { "must be Serializable" ) - val CHECKPOINT_POLICY_CONFIG_KEY = "checkpointPolicy-dev" - /** Policy to decide what kind of checkpoint to write to a table. */ val CHECKPOINT_POLICY = buildConfig[CheckpointPolicy.Policy]( - key = CHECKPOINT_POLICY_CONFIG_KEY, + key = "checkpointPolicy", defaultValue = CheckpointPolicy.Classic.name, fromString = str => CheckpointPolicy.fromName(str), validationFunction = (v => CheckpointPolicy.ALL.exists(_.name == v.name)), diff --git a/spark/src/main/scala/org/apache/spark/sql/delta/TableFeature.scala b/spark/src/main/scala/org/apache/spark/sql/delta/TableFeature.scala index 25956c19d5b..b96ce4da985 100644 --- a/spark/src/main/scala/org/apache/spark/sql/delta/TableFeature.scala +++ b/spark/src/main/scala/org/apache/spark/sql/delta/TableFeature.scala @@ -517,12 +517,9 @@ object IcebergCompatV1TableFeature extends WriterFeature(name = "icebergCompatV1 /** * V2 Checkpoint table feature is for checkpoints with sidecars and the new format and * file naming scheme. - * This is still WIP feature. */ object V2CheckpointTableFeature - extends ReaderWriterFeature( - name = "v2Checkpoint-under-development" - ) + extends ReaderWriterFeature(name = "v2Checkpoint") with FeatureAutomaticallyEnabledByMetadata { override def automaticallyUpdateProtocolOfExistingTables: Boolean = true