Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add nonci_accounts metric #347

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Add nonci_accounts metric #347

merged 1 commit into from
Jul 8, 2024

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Jul 8, 2024

Calculating this with PromQL is not easy
due to interpolation.

Also add HELP and TYPE metadata for each metric.

@link2xt link2xt force-pushed the link2xt/metrics-nonci-accounts branch 3 times, most recently from c37103b to 80baf33 Compare July 8, 2024 14:40
@link2xt link2xt requested review from hpk42, hagenest and missytake and removed request for hpk42 and hagenest July 8, 2024 18:13
Copy link
Contributor

@hpk42 hpk42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if it works ;)

Calculating this with PromQL is not easy
due to interpolation.

Also add HELP and TYPE metadata for each metric.
@link2xt link2xt force-pushed the link2xt/metrics-nonci-accounts branch from 80baf33 to 4292355 Compare July 8, 2024 18:33
@link2xt link2xt merged commit 4292355 into main Jul 8, 2024
5 checks passed
@link2xt link2xt deleted the link2xt/metrics-nonci-accounts branch July 8, 2024 18:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants