fix: use generic output file names

Previously, the CLI produced bundled files that were named
after their package, i.e. denali-auth.fragment.js or
my-cool-app.bundle.js. This introduced a problem, however,
for projects with scoped package names, i.e. @denali-js/babel.
Broccoli would write the resulting fragment file into the literal
`@denali-js/` folder.

This was primarily done to avoid problems when Broccoli tried to merge
all the various addon fragments prior to the source map concat - they'data
all be named the same thing, and thus overwrite each other.

This change converts the compiled output to use generic filenames,
i.e. `addon.fragment.js`. To avoid the overwriting problem, we put
them into folders based on their package name during the build, before
merging them together. The fact the concat step uses a recursive glob
pattern allows us to do this without having to know what those folder
names are at the concat step.

Author: davewasmer

lib/builders/addon.ts

@@ -122,7 +122,7 @@ export default class AddonBuilder extends BaseBuilder {
       header: bundleFragmentOpen(data),
       footer: bundleFragmentClose,
       wrapAsModules: true,
-      outputFile: `${ this.pkg.name }.fragment.js`,
+      outputFile: `addon.fragment.js`,
       baseDir: this.dir
     });
     return tree;

lib/builders/app.ts

@@ -12,6 +12,8 @@ const bundleClose = fs.readFileSync(path.join(__dirname, '..', 'templates', 'bun
 
 export default class AppBuilder extends BaseBuilder {
 
+  bundleName = 'app';
+
   shouldBuildDocs() {
     if (this.options.docs != undefined) {
       return this.options.docs;
@@ -28,17 +30,18 @@ export default class AppBuilder extends BaseBuilder {
     let addonBundles = this.addons.map((addon) => {
       this.debug(`including ${ addon.pkg.name } fragment in app bundle`);
       return new Funnel(addon.toTree(), {
-        include: [
-          `*fragment.js`,
-          `*fragment.map`
+        destDir: addon.pkg.name,
+        files: [
+          `addon.fragment.js`,
+          `addon.fragment.map`
         ]
       });
     });
     tree = new MergeTree(addonBundles.concat(tree), { annotation: 'merge app and addon runtimes' });
     tree = new Concat(tree, {
       header: bundleOpen({ pkgName: this.pkg.name, version: this.pkg.version }),
       footer: bundleClose,
-      outputFile: `${ this.pkg.name }.bundle.js`
+      outputFile: `${ this.bundleName }.bundle.js`
     });
     return tree;
   }

lib/builders/dummy.ts

@@ -10,6 +10,7 @@ import * as Funnel from 'broccoli-funnel';
 export default class DummyBuilder extends AppBuilder {
 
   packageFiles = [ 'package.json' ];
+  bundleName = 'dummy';
 
   addonBuilderUnderTest: AddonBuilder;