Significantly improve CLI startup times #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move a few heavier modules from static imports to lazy `require()`s. Also remove support for globally installed addons via yarn *and* npm. If Yarn is detected, Denali will search Yarn for global addons, otherwise it wills search npm, but not both. This lets Yarn users avoid the delays that npm forces (because we need to shell out for `npm root`, which eats 500ms). We could make this behavior configurable in the future, once we have a ~/.denali config file
davewasmer
force-pushed
the
faster-startup
branch
from
c41508c to
deeff93
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** Before **
** After **
Move a few heavier modules from static imports to lazy
require()s.Also remove support for globally installed addons via yarn and npm.
If Yarn is detected, Denali will search Yarn for global addons, otherwise
it wills search npm, but not both. This lets Yarn users avoid the
delays that npm forces (because we need to shell out for
npm root, whicheats 500ms).
We could make this behavior configurable in the future, once we have
a ~/.denali config file