Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

User control of compile binary meta data #9395

Closed
ghost opened this issue Feb 4, 2021 · 7 comments
Closed

User control of compile binary meta data #9395

ghost opened this issue Feb 4, 2021 · 7 comments
Labels
compile related to the `deno compile` feature feat new feature (which has been agreed to/accepted)

Comments

@ghost
Copy link

ghost commented Feb 4, 2021

Hi.

  1. Do I have the right to sell a CLI application written with the Deno compile command?
    The information contains copyright information

Screenshot_1

  1. If I want to make a free open source CLI app - can I change the Deno icon?
    If so, how do I do it?

Thanks...

@ry
Copy link
Member

ry commented Feb 4, 2021

Yes you can sell the output of “deno compile”.... we probably need to do some work to remove logo and other metadata...

@kitsonk kitsonk added compile related to the `deno compile` feature feat new feature (which has been agreed to/accepted) labels Feb 4, 2021
@kitsonk kitsonk changed the title Juridical. right of ownership. User control of compile binary meta data Feb 4, 2021
@eliassjogreen
Copy link
Contributor

Related to #8912, would require rc.exe on windows.

@ghost
Copy link

ghost commented Feb 19, 2021

In golang, there is an option for launching the executable in "GUI" mode, in order to hide the console:

go build -ldflags "-H windowsgui" -o application.exe

This is something that would be nice to have too in deno, for example in the case of a GUI application launched with the default browser and coupled to a local deno backend. Double-clicking the compiled deno application file would only open the default browser via Deno.open(url), and not the deno console itself.

@Leokuma
Copy link

Leokuma commented Dec 25, 2023

Guys, I made a Deno program that allows you to compile Deno apps with custom icon and metadata: https://github.com/Leokuma/wincompile

@littledivy
Copy link
Member

Icons are now supported: deno compile --icon icon.ico (#25039)

Other metadata is cleared by default for binaries produced by deno compile

@RossAscends
Copy link

with a valid (used as a desktop icon in the past) icon.ico in the same directory as main.ts, and using this command:

deno compile --icon icon.ico --target x86_64-pc-windows-msvc --allow-net --allow-write --allow-read main.ts

..the exe compiles and runs correctly, and the filesize is larger than with no icon embedded (so the file is getting in there), but there is no icon showing up, and not even an option to set an icon for the EXE in the Windows properties popup.

@bartlomieju
Copy link
Member

@RossAscends I suggest to open a new issue for that problem, commenting on a closed issue is easy to miss for maintainers.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
compile related to the `deno compile` feature feat new feature (which has been agreed to/accepted)
Projects
None yet
Development

No branches or pull requests

8 participants