From 6ed9efb47b5f640cb5918529121e1f691f487413 Mon Sep 17 00:00:00 2001 From: Tim Date: Tue, 11 Feb 2025 09:23:41 +0100 Subject: [PATCH] fix minor NaN value bug --- semver/parse_range.ts | 4 ++-- semver/parse_range_test.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/semver/parse_range.ts b/semver/parse_range.ts index cddf4ec2d8e2..e2ba5211a07d 100644 --- a/semver/parse_range.ts +++ b/semver/parse_range.ts @@ -253,7 +253,7 @@ function handleLessThanOperator(groups: RangeRegExpGroups): Comparator[] { if (majorIsWildcard) return [{ operator: "<", major: 0, minor: 0, patch: 0 }]; if (minorIsWildcard) { if (patchIsWildcard) return [{ operator: "<", major, minor: 0, patch: 0 }]; - return [{ operator: "<", major, minor, patch: 0 }]; + return [{ operator: "<", major, minor: 0, patch: 0 }]; } if (patchIsWildcard) return [{ operator: "<", major, minor, patch: 0 }]; const prerelease = parsePrerelease(groups.prerelease ?? ""); @@ -316,7 +316,7 @@ function handleGreaterOrEqualOperator(groups: RangeRegExpGroups): Comparator[] { if (majorIsWildcard) return [ALL]; if (minorIsWildcard) { if (patchIsWildcard) return [{ operator: ">=", major, minor: 0, patch: 0 }]; - return [{ operator: ">=", major, minor, patch: 0 }]; + return [{ operator: ">=", major, minor: 0, patch: 0 }]; } if (patchIsWildcard) return [{ operator: ">=", major, minor, patch: 0 }]; const prerelease = parsePrerelease(groups.prerelease ?? ""); diff --git a/semver/parse_range_test.ts b/semver/parse_range_test.ts index 405abf627568..a0d91ab52838 100644 --- a/semver/parse_range_test.ts +++ b/semver/parse_range_test.ts @@ -672,13 +672,13 @@ Deno.test("parseRange() handles wildcards", () => { [{ operator: "<", major: 1, minor: 0, patch: 0 }], ]); assertEquals(parseRange("<1.*.0"), [ - [{ operator: "<", major: 1, minor: NaN, patch: 0 }], + [{ operator: "<", major: 1, minor: 0, patch: 0 }], ]); assertEquals(parseRange("<1.*.*"), [ [{ operator: "<", major: 1, minor: 0, patch: 0 }], ]); assertEquals(parseRange(">=1.*.0"), [ - [{ operator: ">=", major: 1, minor: NaN, patch: 0 }], + [{ operator: ">=", major: 1, minor: 0, patch: 0 }], ]); assertEquals(parseRange(">=1.*.*"), [ [{ operator: ">=", major: 1, minor: 0, patch: 0 }],