Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Need to bump to newest gomodules extracted tag #3569

Closed
jeffwidman opened this issue Apr 28, 2021 · 5 comments
Closed

Need to bump to newest gomodules extracted tag #3569

jeffwidman opened this issue Apr 28, 2021 · 5 comments
Labels
T: bug 🐞 Something isn't working

Comments

@jeffwidman
Copy link
Member

Once dependabot/gomodules-extracted#9 is merged and a new version cut, need to update the tag in this repo. See #2619 for an example of how it was done last time around.

@jeffwidman jeffwidman added the T: bug 🐞 Something isn't working label Apr 28, 2021
@jeffwidman
Copy link
Member Author

Actually, looks like both of these files will need updating, and only one of them was previously updated:

  1. github.com/dependabot/gomodules-extracted v1.2.0
  2. require github.com/dependabot/gomodules-extracted v0.0.0-20181020215834-1b2f850478a3

@jeffwidman
Copy link
Member Author

See also #3576 which simply removes the go_modules/helpers/updater/go.mod file, so that there's only one canonical place to update.

@jeffwidman
Copy link
Member Author

jeffwidman commented Apr 28, 2021

The two bits that are imported from internal stuff both had breaking changes. 😢

The modfetch.Lookup signature is easy, they stopped returning an error: golang/go@c921157.

modload.InitMod was refactored here: golang/go@d05e89a. It appears that we only need the LoadModFile bits, not the CreateModFile bits... so modload.LoadModFile(context.Background()) should suffice.

@jeffwidman
Copy link
Member Author

See also discussion #3590 (comment) which would allow completely removing this code altogether.

@jeffwidman
Copy link
Member Author

Closed in #3632

@thepwagner quick reminder that you need to manually close these bugs when the PR gets merged... github won't auto-close the ticket unless the PR has something auto-parseable like Fix #3569...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
T: bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant