Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Activate Multiple Plugins before a server restart #1351

Closed
RayBenefield opened this issue Apr 6, 2014 · 2 comments
Closed

Activate Multiple Plugins before a server restart #1351

RayBenefield opened this issue Apr 6, 2014 · 2 comments
Assignees
Milestone

Comments

@RayBenefield
Copy link

Upon doing a ./nodebb restart it can be a pain to re-turn on a ton of plugins, particularly due to the amount of time it takes to minify client-side libraries. It would be nice to be able to select which plugins will be activated before the server begins restarting.

This could be done in several different ways, I vaguely remember the auto-start was a nice convenience feature. So what if there was a "Restarting in 5... 4... 3... 2... 1..." that gets reset whenever a new plugin is activated? I mean a series of checkboxes or something with a restart button would be fine, but it takes away the auto-restart feature that is actually nice to have on a one-of plugin activation.

I had the time to write this while activating each plugin, one at a time... lol.

@julianlam
Copy link
Member

Planning to actively remove the forced restarting for all ACP options, and go back to a "Restart your NodeBB" alertbox. At least the process is a little faster on edge builds right now, since JS minification is handled in a separate thread, so NodeBB can snap back into responsivity sooner. (As JS is only required on cold loads, you can continue to browse the ACP, etc)

Admins can restart NodeBB by hitting the restart button in "ACP/Home"

  • Remove forced restart on all ACP pages
  • Set in-memory flag to remind admins to restart (if necessary)

@julianlam julianlam added this to the 0.4.1 milestone Apr 6, 2014
@julianlam julianlam self-assigned this Apr 6, 2014
@RayBenefield
Copy link
Author

I'm ok with this. ;)

@julianlam julianlam reopened this Apr 16, 2014
julianlam added a commit to NodeBB/nodebb-theme-vanilla that referenced this issue Apr 16, 2014
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants