Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve x/posts structures names #895

Open
leobragaz opened this issue Jun 8, 2022 · 3 comments
Open

Improve x/posts structures names #895

leobragaz opened this issue Jun 8, 2022 · 3 comments
Labels
quality/code-cleanliness Improves the overall quality of code

Comments

@leobragaz
Copy link
Contributor

After reviewing the #893 I've realised that there are some confusing structures names that don't really express the intend
of those types. I think both SubspaceDataEntry and PostDataEntry should be renamed to a more meaningful
SubspaceRelatedIDs and PostRelatedIDs. This will help to give a better context to the the types and ease the life of devs understanding what they're about.

@leobragaz leobragaz added x/posts Post module kind/new-feature Propose the addition of a new feature that does not yet exist labels Jun 8, 2022
@RiccardoM
Copy link
Contributor

Those are internal structures, used only when importing/exporting the genesis state. They shouldn't be used by external developers and hence their names. I don't think it's necessary to change them

@leobragaz
Copy link
Contributor Author

Also for our internal usage that would be useful.

@RiccardoM
Copy link
Contributor

Let's make this extremely low priority then

@RiccardoM RiccardoM added quality/tests Improves the test suite quality/code-cleanliness Improves the overall quality of code and removed x/posts Post module kind/new-feature Propose the addition of a new feature that does not yet exist quality/tests Improves the test suite labels Jun 9, 2022
@RiccardoM RiccardoM changed the title Improving x/posts structures names Improve x/posts structures names May 3, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
quality/code-cleanliness Improves the overall quality of code
Projects
None yet
Development

No branches or pull requests

2 participants