New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Switch to eslint #1

Open

hampelm opened this issue Jan 7, 2017 · 1 comment

Member

hampelm commented Jan 7, 2017

http://eslint.org/

jshint doesn't like JSX

Member

bnchdrff commented Jan 8, 2017

agree.

i put a config in package.json and it's in node_modules/.bin/eslint but i don't have a runner set up

how about we run it with npm test before our other tests (of the future) run?

npm test could invoke a script test.sh that looks like this:

#!/usr/bin/env bash

echo 'eslint should not report any errors...'
./node_modules/.bin/eslint .
if [ "$?" != "0" ]; then
  echo "eslint failed." 1>&2
  exit 1
fi

echo 'jest tests should pass...'
./node_modules/.bin/jest
if [ "$?" != "0" ]; then
  echo "jest failed." 1>&2
  exit 1
fi

hampelm changed the title ~~Try using ESLint~~ Switch to eslint

# for free to join this conversation on GitHub. Already have an account? # to comment