Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

The index server shouldn't return null if no samples exist #540

Closed
johnmcollier opened this issue Jul 15, 2021 · 3 comments
Closed

The index server shouldn't return null if no samples exist #540

johnmcollier opened this issue Jul 15, 2021 · 3 comments
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure good first issue Good for newcomers kind/bug Something isn't working

Comments

@johnmcollier
Copy link
Member

johnmcollier commented Jul 15, 2021

/kind bug

Which area this bug is related to?

/area registry

Bug Summary

The index server currently returns null if no samples are in the registry when the /index/sample endpoint is called:

johncollier@jcollier-mac ~ % curl https://devfile-registry-devfile-registry-redhat-production.apps.app-sre-prod-03.z5a2.p1.openshiftapps.com/index/sample
null

To Reproduce:

$ curl https://devfile-registry-devfile-registry-redhat-production.apps.app-sre-prod-03.z5a2.p1.openshiftapps.com/index/sample
null

Expected behavior

Either an empty array should be returned instead, or perhaps a more proper error message than null.

@openshift-ci openshift-ci bot added kind/bug Something isn't working area/registry Devfile registry for stacks and infrastructure labels Jul 15, 2021
@michael-valdron michael-valdron moved this to Backlog in Devfile Project Jul 27, 2023
@michael-valdron michael-valdron added the good first issue Good for newcomers label Sep 27, 2023
@Horiodino
Copy link

hi how about I work on this issue and get some idea about the project :)
it is possible to provide the files where to make changes!

@michael-valdron
Copy link
Member

hi how about I work on this issue and get some idea about the project :) it is possible to provide the files where to make changes!

Hi @Horiodino,

Sounds good! We welcome your contribution to this issue!

Reviewing index/server/pkg/server/endpoint.go would be a good starting point for resolving this bug.

For more information refer to our README or reach out to us on our community channel (which I see you have joined) if you have any questions 😄

@michael-valdron
Copy link
Member

Completed with devfile/registry-support#246

@github-project-automation github-project-automation bot moved this from Backlog to Done ✅ in Devfile Project Jul 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/registry Devfile registry for stacks and infrastructure good first issue Good for newcomers kind/bug Something isn't working
Projects
Status: Done ✅
Development

No branches or pull requests

3 participants