Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Operator._prepare_arguments needs refactoring to remove Thickness loop #2483

Open
EdCaunt opened this issue Nov 13, 2024 · 0 comments
Open
Assignees
Labels

Comments

@EdCaunt
Copy link
Contributor

EdCaunt commented Nov 13, 2024

Operator._prepare_arguments currently contains the following lines:

# Process Thicknesses
for p in self.parameters:
    if isinstance(p, Thickness):
    args.update(p._arg_values(grid=grid, **kwargs))

which could be removed by making Thickness have is_Input = True and moving grid processing to before _arg_values is called on inputs.

However, as pending PRs make changes to this code, this should be returned to later to avoid messy merge conflicts.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants