Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

"godep save ./..." fails with vendor directory #387

Closed
ericchiang opened this issue Mar 29, 2016 · 7 comments
Closed

"godep save ./..." fails with vendor directory #387

ericchiang opened this issue Mar 29, 2016 · 7 comments

Comments

@ericchiang
Copy link
Contributor

Now that we use the vendor directory the go tool ./... expression detects all packages in the vendor directory. godep save ./..., our recommended way of adding new packages, attempts to save all the dependencies of the vendored dependencies. Blah.

Also note that go list ./... | grep -v vendor fails so we can't use that ATM to filter out packages.

$ go list ./... | grep -v './vendor'
can't load package: /home/eric/src/github.com/coreos/dex/schema/generator_import.go:10:8: import "google.golang.org/api/google-api-go-generator" is a program, not an importable package

Either figure out how to get around this with godep and update the dev docs (for example what rkt does) or consider being a guinea pig for coreos/docs#775

@bobbyrullo
Copy link
Contributor

ugggh. I vote for coreos/docs#775, with glide specifically.

@ericchiang
Copy link
Contributor Author

From conversations with bobby, we should switch to rkt's setup for vendoring applications (make a custom godep-save wrapper). In the future we'll consider glide.

@ericchiang
Copy link
Contributor Author

FYI, I tried moving dex over to glide as a POC and it worked pretty well. coreos/docs#775 (comment)

@bobbyrullo
Copy link
Contributor

@ericchiang is there any reason to not just go for it?

@ericchiang
Copy link
Contributor Author

Nope, just want to make sure there's not push back on the other thread. I'll push up the glide changes for review.

@sym3tri
Copy link

sym3tri commented Apr 9, 2016

@ericchiang were you able to vendor the dependencies in git? I know there's some extra work to get that working properly. Assuming that all went well, I am +1. I like glide, but not the git submodules.

@ericchiang
Copy link
Contributor Author

@sym3tri Yeah! There's some good discussion in coreos/docs#775. A couple comments down I talked about trying to move dex over without submodules.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants