-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
"godep save ./..." fails with vendor directory #387
Comments
ugggh. I vote for coreos/docs#775, with glide specifically. |
From conversations with bobby, we should switch to rkt's setup for vendoring applications (make a custom godep-save wrapper). In the future we'll consider glide. |
FYI, I tried moving dex over to glide as a POC and it worked pretty well. coreos/docs#775 (comment) |
@ericchiang is there any reason to not just go for it? |
Nope, just want to make sure there's not push back on the other thread. I'll push up the glide changes for review. |
@ericchiang were you able to vendor the dependencies in git? I know there's some extra work to get that working properly. Assuming that all went well, I am +1. I like glide, but not the git submodules. |
@sym3tri Yeah! There's some good discussion in coreos/docs#775. A couple comments down I talked about trying to move dex over without submodules. |
Now that we use the
vendor
directory the go tool./...
expression detects all packages in thevendor
directory.godep save ./...
, our recommended way of adding new packages, attempts to save all the dependencies of the vendored dependencies. Blah.Also note that
go list ./... | grep -v vendor
fails so we can't use that ATM to filter out packages.Either figure out how to get around this with godep and update the dev docs (for example what rkt does) or consider being a guinea pig for coreos/docs#775
The text was updated successfully, but these errors were encountered: