lambda integration: all responses are empty due to default template file containing newline.

[bebbi]

I'm using lambda integration.

My responses are all newlines only instead of the lambda response data.

I've tracked this down to this projects offline-default.res.vm file to contain only a newline.

I'd be happy to PR the correct default template into this file, but I don't know where to source it.

[bebbi]

OK some more info here. The manual_test helloLambdaIntegration funcs work due to a bug in the implementation.

If we go through the example, and call the above func:
In this line

serverless-offline/src/index.js

Line 671 in 889b640

const responseTemplate = responseTemplates[responseContentType];

responseTemplates is

{
  application/json;charset=UTF-8: ""
}

And responseContentType is application/json, so in that line, no match returns undefined.

Which fails the test in

serverless-offline/src/index.js

Line 673 in 889b640

if (responseTemplate) {

Whereas in my case, I defined the response headers application/json in serverless.yml, and perhaps because of this, the default template (newline) got associated and responseTemplate looks like this:

{
  application/json;charset=UTF-8: ""
  application/json: "\n"
}

which passes the above test, triggers template mapping and then fails to return data because the newline is not a valid template.

I'm going to submit the quick fix of removing the newline from the default mapping. I will also add a newline check for the template check above because the newline in the template file could easily be re-introduced via some linter (probably was in the first place). But it would be good to check the general implementation as well aside from those fixes.

[dherault]

Hi, I'm back from holidays. Thank you for your patience. I'll review all the issues and PRs in the upcoming days and will ship asap.

[dherault]

Thanks @bebbi !