-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: remove cli util, update cypress to v12 & small conceptual adjustments #393
Conversation
BREAKING CHANGE: cypress 12 uses a different naming scheme for folders, files and extensions
BREAKING CHANGE: This removes the `d2-utils-cypress` cli tool! Reason for this being a fix, see: https://stackoverflow.com/a/55213921/1319140 I'd agree that this is actually removing something we could consider a "conceptual bug", because this kind of stuff shouldn't really be there in the first place. Removing the code that's been deleted allows us to better educate developers how to use cypress the way we thing it works best within our environment without hiding/wrapping any of cypress' functionality and instead making developers learn how to use vanilla cypress.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great stuff! There are a few points we need to discuss in the comments. And I also wonder how we should deal with removing a package. Probably we need to make sure we mention on NPM that it is deprecated.
# [10.0.0](v9.0.2...v10.0.0) (2023-04-27) ### Features * remove cli util, update cypress to v12 & small conceptual adjustments ([#393](#393)) ([855e259](855e259)) ### BREAKING CHANGES * cypress 12 uses a different naming scheme for folders, files and extensions * This removes the `d2-utils-cypress` cli tool! Co-authored-by: Hendrik de Graaf <hendrik@dhis2.org>
🎉 This PR is included in version 10.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
cy.login
(now there's acy.fillInLoginForm
command which can be used together withcy.session
)d2-cli-cypress
tool is gone, it's not needed anymore (it is actually still there (theinstall
command), but does nothing; as discussed with @HendrikThePendric)How to review this PR
There are several things that should be checked:
d2-utils-cypress install
command does nothing, just informing the user that the command is not supported anymoreHow to test
Example apps
yarn test:examples
(will start the example apps & run cypress tests, which includes both capturing and stubbing in the example app that uses the network shim)Real app
yarn workspace @dhis2/cypress-commands build
)yarn workspace @dhis2/cypress-commands link && yarn workspace @dhis2/cypress-plugins link
)upgrade-cypress-to-v12
branch of the aggregate data entry app (related PR: chore: update cypress to v12 and upgrade related configs & code aggregate-data-entry-app#319)yarn link @dhis2/cypress-plugins @dhis2/cypress-commands
)yarn cypress:start
)yarn cypress:open:live
) and/or capturing/stubbing network requests (yarn cypress:run:capture && yarn cypress:run:stub
)