-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Combine issues/PRs comments into one #41
Comments
Yep, this is really annoying. As a temporary workaround we just recommend to disable github plugin comments. module.exports = {
branch: 'master',
plugins: [
'@semantic-release/commit-analyzer',
'@semantic-release/release-notes-generator',
'@semantic-release/changelog',
'@semantic-release/npm',
[
'@semantic-release/github',
{
successComment: false,
failComment: false
}
],
'@semantic-release/git'
]
} |
This is probably related to the same underlying issue. I notice that when a new packages is added to an existing monorepo the initial release of the package results addeding the release success comment on every PR/Issue before it. Like the commits aren't filtered. It updates months worth of prs and GitHub sends out dozens of email notifications |
Is this what the |
It seems something went wrong here. } else {
const parser = issueParser('github', githubUrl ? {hosts: [githubUrl]} : {});
const releaseInfos = releases.filter((release) => Boolean(release.name));
const shas = commits.map(({hash}) => hash);
const searchQueries = getSearchQueries(`repo:${owner}/${repo}+type:pr+is:merged`, shas).map(
async (q) => (await github.search.issuesAndPullRequests({q})).data.items
); We need to debug this point to make sure, that only filtered commits are passed to plugin method. |
@antongolub Making a new issue so this doesn't get lost |
Each release add a comment to the related issue and pr. Combine the comments into one making a better life.
The text was updated successfully, but these errors were encountered: