Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

irregular past part in the lexicon #186

Open
3 tasks done
Real-John-Cheung opened this issue Jun 30, 2022 · 4 comments
Open
3 tasks done

irregular past part in the lexicon #186

Real-John-Cheung opened this issue Jun 30, 2022 · 4 comments
Assignees

Comments

@Real-John-Cheung
Copy link
Collaborator

Real-John-Cheung commented Jun 30, 2022

we currently have a list of irregular past part in conjugator.js (const IRREG_PAST_PART). some of the words in it are in the lexicon and some of them are not.
we need to

  • sort out which of them are not in the lexicon
  • decide if we want (some of ) them to be in the lexicon
  • add the missing one to the lexicon

#185

@Real-John-Cheung
Copy link
Collaborator Author

Sorry, in the deleted comment I forgot to check if the word is also correctly tagged
here is the past part that need to be added
const IRREG_PAST_PART_NOT_IN_DICT = ["abode","begotten","bidden","borne","chlung","could","mown","pled","relaid","shod","smelt","spelt","spolit","taight","wrung"];
not a lot, I still think we can add them all to the lexicon

@dhowe
Copy link
Owner

dhowe commented Jul 10, 2022

how did you generate the list above ? some of those seem strange or possibly incorrect

@Real-John-Cheung
Copy link
Collaborator Author

I generate the list simply by going over IRREG_PAST_PART in conjugator.js and checking if lexicon has that entry and if it is tagged as vbd or vbn. I will check if all the words in IRREG_PAST_PART is correct first.

@Real-John-Cheung
Copy link
Collaborator Author

Real-John-Cheung commented Jul 10, 2022

updated list with desire tags(empty array indicates tags to be confirmed, words from ginger software included)

const IRREG_PAST_PART_IN_DICT = {"arose":["vbd"],"awoke":["vbd"],"beat":["vbd"],"became":["vbd"],"began":["vbd"],"bent":["vbd","vbn"],"bet":["vbd","vbn"],"bound":["vbd","vbn"],"bit":["vbd"],"bled":["vbd"],"blew":["vbd"],"broke":["vbd"],"bred":["vbd","vbn"],"brought":["vbd","vbn"],"broadcast":["vbd","vbn"],"built":["vbd","vbn"],"burst":["vbd","vbn"],"bought":["vbd","vbn"],"caught":["vbd","vbn"],"chose":["vbd"],"clung":["vbd","vbn"],"came":["vbd"],"crept":["vbd","vbn"],"cut":["vbd","vbn"],"dealt":["vbd","vbn"],"dug":["vbd","vbn"],"did":["vbd"],"drew":["vbd"],"dreamt":["vbd","vbn"],"drank":["vbd"],"drove":["vbd"],"ate":["vbd"],"fell":["vbd"],"fed":["vbd"],"felt":["vbd","vbn"],"fought":["vbd","vbn"],"found":["vbd","vbn"],"flew":["vbd"],"forbade":["vbd"],"forgot":["vbd"],"forgave":["vbd"],"froze":["vbd"],"got":["vbd"],"gave":["vbd"],"went":["vbd"],"ground":["vbd","vbn"],"grew":["vbd"],"hung":["vbd","vbn"],"had":["vbd","vbd","vbn"],"hid":["vbd"],"hit":["vbd","vbn"],"held":["vbd","vbn"],"hurt":["vbd","vbn"],"kept":["vbd","vbn"],"knelt":["vbd","vbn"],"knew":["vbd"],"laid":["vbd","vbn"],"led":["vbd","vbn"],"left":["vbd","vbn"],"lent":["vbd","vbn"],"lay":["vbd"],"lit":["vbd","vbn"],"lost":["vbd","vbn"],"made":["vbd","vbn"],"meant":["vbd","vbn"],"met":["vbd","vbn"],"overtook":["vbd"],"paid":["vbd","vbn"],"put":["vbd","vbn"],"read":["vbd","vbn"],"rode":["vbd"],"rang":["vbd"],"rose":["vbd"],"ran":["vbd"],"said":["vbd","vbn"],"saw":["vbd"],"sold":["vbd","vbn"],"sent":["vbd","vbn"],"set":["vbd","vbn"],"shook":["vbd"],"shed":["vbd","vbn"],"shone":["vbd","vbn"],"shot":["vbd","vbn"],"shrank":["vbd"],"shut":["vbd","vbn"],"sang":["vbd"],"sank":["vbd"],"sat":["vbd","vbn"],"slept":["vbd","vbn"],"slid":["vbd","vbn"],"spoke":["vbd"],"spent":["vbd","vbn"],"spat":["vbd"],"spread":["vbd","vbn"],"stood":["vbd","vbn"],"stole":["vbd"],"stuck":["vbd","vbn"],"stung":["vbd","vbn"],"struck":["vbd","vbn"],"swore":["vbd"],"swept":["vbd","vbn"],"swelled":["vbd"],"swam":["vbd"],"swung":["vbd","vbn"],"took":["vbd"],"taught":["vbd","vbn"],"tore":["vbd"],"told":["vbd","vbn"],"thought":["vbd","vbn"],"threw":["vbd"],"understood":["vbd","vbn"],"woke":["vbd"],"wore":["vbd"],"wept":["vbd","vbn"],"won":["vbd","vbn"],"wound":["vbd","vbn"],"wrote":["vbd"],"arisen":["vbn"],"beaten":["vbn"],"become":["vbn"],"begun":["vbn"],"bitten":["vbn"],"blown":["vbn"],"broken":["vbn"],"chosen":["vbn"],"come":["vbn"],"done":["vbn"],"drawn":["vbn"],"drunk":["vbn"],"driven":["vbn"],"eaten":["vbn"],"fallen":["vbn"],"flown":["vbn"],"forbidden":["vbn"],"forgotten":["vbn"],"forgiven":["vbn"],"frozen":["vbn"],"given":["vbn"],"gone":["vbn"],"grown":["vbn"],"hidden":["vbn"],"known":["vbn"],"lain":["vbn"],"overtaken":["vbn"],"ridden":["vbn"],"rung":["vbn"],"risen":["vbn"],"run":["vbn"],"seen":["vbn"],"sewn":["vbn"],"shaken":["vbn"],"shown":["vbn"],"shrunk":["vbn"],"sung":["vbn"],"sunk":["vbn"],"sown":["vbn"],"spoken":["vbn"],"stolen":["vbn"],"sworn":["vbn"],"swollen":["vbn"],"swum":["vbn"],"taken":["vbn"],"torn":["vbn"],"thrown":["vbn"],"woken":["vbn"],"worn":["vbn"],"written":["vbn"],"been":[],"bid":[],"born":[],"clad":[],"dove":[],"dwelt":[],"fled":[],"flung":[],"slain":[],"sought":[],"sped":[],"split":[],"sprung":[],"spun":[],"stunk":[],"undergone":[]};

const IRREG_PAST_PART_NOT_IN_DICT = {"bore":["vbd"],"could":["vbd"],"cost":["vbd","vbn"],"heard":["vbd","vbn"],"leant":["vbd","vbn"],"learnt":["vbd","vbn"],"lied":["vbd","vbn"],"might":["vbd"],"mown":["vbd"],"sawn":["vbn"],"sewed":["vbd"],"should":["vbd"],"showed":["vbd"],"smelt":["vbd","vbn"],"sowed":["vbd"],"spelt":["vbd","vbn"],"spilt":["vbd","vbn"],"stank":["vbd"],"would":["vbd"],"awoken":["vbn"],"borne":["vbn"],"bled":["vbn"],"fed":["vbn"],"got":["vbn"],"mown":["vbn"],"to":["vbn"],"sawn":["vbn"],"spat":["vbn"],"stunk":["vbn"],"bidden":["vbn"],"pled":["vbd"],"relaid":["vbd"],"wrung":["vbd", "vbn"]};

I will check the tags for words in lexicon first

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants