Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrading to A-Frame 1.5.0 #37

Closed
diarmidmackenzie opened this issue Nov 19, 2023 · 3 comments
Closed

Upgrading to A-Frame 1.5.0 #37

diarmidmackenzie opened this issue Nov 19, 2023 · 3 comments

Comments

@diarmidmackenzie
Copy link
Owner

Mostly works with 1.5.0, but upgrading all the examples has revealed a handful of issues.

  1. color changes in some examples. This is due to previously bugged code, using A-Frame 1.4.2 and colorManagement: true, calls should be made to applyColorCorrection, when using THREE.js Color() directly. This is handled automatically in 1.5.0. Where these calls were missing, the examples were previously showing the "wrong" colors, and are now correct.

  2. physics-ammo.html

Hits error when re-spawning a ball.

ReferenceError: body is not defined

To be investigated under c-frame/aframe-physics-system

  1. updates.html & updates-multi-mesh.html

When mesh capacity is updated, a large instance appears at the origin, and frame rate drops (particularly noticeable with the multi-mesh example).

This requires further investigation.

@diarmidmackenzie
Copy link
Owner Author

Physics problem is nothing to do with 1.5.0, just a bug in aframe-physics-system - fixed here: c-frame/aframe-physics-system#54

@diarmidmackenzie
Copy link
Owner Author

Problem 3 turns out to be a regression in 1.4.0. Issue was instancedMesh.count not being set up correctly on initialization, so additional instances without specified matrices were being rendered.

Problem didn't appear at 1.3.0 - not sure why, but new code should be better for all versions.

Fix here:
e11ef10

@diarmidmackenzie
Copy link
Owner Author

Addressed by #38

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant