Skip to content

Remove boxing from futures example #26

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
dimbleby opened this issue Oct 15, 2016 · 2 comments
Closed

Remove boxing from futures example #26

dimbleby opened this issue Oct 15, 2016 · 2 comments

Comments

@dimbleby
Copy link
Owner

The example in cares_futures.rs currently has queries returning BoxFuture. That's an unnecessary allocation best avoided by returning impl Future - if and when that stabilises.

See rust-lang/rust#34511.
@dimbleby
Copy link
Owner Author

Now using an unboxed structure, will go to impl Future when we get there... but I don't think I need this issue to remind me.

@ndusart
Copy link

ndusart commented May 10, 2018

@dimbleby impl Trait is stable now 🎉

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dimbleby @ndusart