Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor Route Pages #777

Closed
8 tasks done
jtfairbank opened this issue Oct 18, 2022 · 4 comments
Closed
8 tasks done

Refactor Route Pages #777

jtfairbank opened this issue Oct 18, 2022 · 4 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest Refactor Cleanup part of the codebase without changing functionality

Comments

@jtfairbank
Copy link
Contributor

jtfairbank commented Oct 18, 2022

Description

It'd be helpful to refactor portions of the route page into their own components, similar to the home page or about-us page. There's some existing routes components in /src/components/routes but those have more to do with structuring the content than separating it. It'd be good to have separate components for each section of content, which still use the existing components to structure themselves.

CodeSee Map of relevant files.

This should pave the way for:

  1. Refactoring the route page's legacy styles to use tailwind classes (see Refactor Custom CSS Classes in Stylesheets > Tailwind Classes #772)
  2. Pulling more of the content out to be controlled by Forestry (our CMS) instead of hard-coded onto the page.
  3. Reusable chunks of content that can be applied elsewhere (such as an FAQ).

Checklist

  • Add your name to /CONTRIBUTORS.md if this is your first contribution!
  • Delivery Section => Component
  • Reservations Section => Component
  • Frontline Section => Component
  • Staging Hubs Section => Component
  • Costs Section => Component
  • About Pallets Section => Component

Front end feature screenshots

This refactoring shouldn't change how the content appears on the website.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jtfairbank jtfairbank added good first issue Good for newcomers hacktoberfest Refactor Cleanup part of the codebase without changing functionality triage An issue needs further analysis by a team member and removed triage An issue needs further analysis by a team member labels Oct 18, 2022
@RabeaGleissner RabeaGleissner self-assigned this Oct 20, 2022
@RabeaGleissner
Copy link
Contributor

I'll start with the Delivery section!

@linds0202
Copy link
Contributor

I would like to work on refactoring the 'Costs' and 'About Pallets' components

@RabeaGleissner
Copy link
Contributor

Hoping to raise a PR for Frontline and Staging Hubs sections soon!

@jtfairbank
Copy link
Contributor Author

Hey @RabeaGleissner @linds0202 thanks so much for tackling this one! If you want to continue with refactoring-related work, I'd suggest looking at #772? If figure there's enough there that y'all can split it up with @20RitikSingh?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue Good for newcomers hacktoberfest Refactor Cleanup part of the codebase without changing functionality
Projects
None yet
Development

No branches or pull requests

3 participants