Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix CI Dashboard unit testing #2984

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@ if [[ ${GITTOP} =~ "fatal: unsafe repository ('/home/root/pbench'" ]] ; then
fi

# Install the Dashboard dependencies, including the linter's dependencies and
# the unit test dependencies.
( cd dashboard && npm install )
# the unit test dependencies. First, remove any existing Node modules and
# package-lock.json to ensure that we install the latest.
( cd dashboard && rm -rf node_modules package-lock.json && npm install )

# Test for code style and lint
black --check .
Expand Down
4 changes: 2 additions & 2 deletions dashboard/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"jest": "^27.5.1",
"js-cookie": "^3.0.1",
"less-watch-compiler": "^1.16.3",
"nvm": "0.0.4",
"patternfly": "^3.9.0",
"react": "^17.0.2",
"react-app-rewired": "^2.2.1",
Expand Down Expand Up @@ -88,6 +87,7 @@
"jsdoc": "^3.6.10",
"less": "^4.1.2",
"less-loader": "^11.0.0",
"prettier": "^2.6.2"
"prettier": "^2.6.2",
"tough-cookie": "^4.1.2"
}
}