Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

return copies lock value: github.com/distribworks/dkron/v4/types.Execution contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex #1601

Open
BrainGithub opened this issue Oct 20, 2024 · 2 comments

Comments

@BrainGithub
Copy link
Contributor

Describe the bug
https://github.com/distribworks/dkron/blob/main/plugin/execution_processor.go#L50

return copies lock value: github.com/distribworks/dkron/v4/types.Execution contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex

this may result in unnecessary lock contention and concurrency issues.

To Reproduce
compile error

Expected behavior
no compile error

@BrainGithub
Copy link
Contributor Author

is anyone took this already? I would like to fix this, if not yet.

@vcastellm
Copy link
Member

Sure, go ahead @BrainGithub

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants