Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fill color by url does not work #52

Closed
joda-divid opened this issue Oct 20, 2021 · 0 comments · Fixed by #53
Closed

fill color by url does not work #52

joda-divid opened this issue Oct 20, 2021 · 0 comments · Fixed by #53

Comments

@joda-divid
Copy link
Contributor

After the change to use lowerCase for fill/stroke/color even in-svg definitions went to lowerCase and do no longer match, e.g. fill="url(#Pattern)"

Suggesting exception to lowerCase if the string contains url.

(This will likely cause problems if anyone uses the namedColor burlywood and spells it with upperCase, but since this is not intended to be a long term solution but only while alafr/SVG-to-PDFKit#152 isn't fixed, that drawback feels acceptable to me.)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant