Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

April 4 2023 nightly hangs forever #41

Open
snomos opened this issue Apr 18, 2023 · 6 comments
Open

April 4 2023 nightly hangs forever #41

snomos opened this issue Apr 18, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@snomos
Copy link
Member

snomos commented Apr 18, 2023

To repeat:

  • download latest nightly
  • quit previous version
  • install new version
  • quit new version
  • open new version
  • switch to the All Repositories view

Result: spinning wheel forever, no message whatsoever, see screenshot:

Skjermbilde 2023-04-18 kl  08 55 14

It has now been runing for at least 10 minutes.

Expected: list of available packages, alternatively the new message that it could not connect, with hints of what to do.

@snomos snomos added the bug Something isn't working label Apr 18, 2023
@snomos
Copy link
Member Author

snomos commented Apr 18, 2023

Restarting the app did indeed fix the hang (the list of available packages did appear). The bug is thus that the message about connection issues with a suggestion to restart the app did NOT appear.

@dylanhand
Copy link
Contributor

We took a look into this. Just for our records, this bug existed before the April 4 nightly and was not introduced by recent loading spinner changes.

@dylanhand
Copy link
Contributor

Following up on the discussion of UI refresh bug in #48:

I'm still unable to reproduce this issue. I did however find that one of our dependencies had the following warning that it may pose a hang risk:
CleanShot 2024-05-07 at 14 06 55@2x

It's been updated. I'd be surprised if that was the fix, but can't hurt.

I'll report back when a build is available. Currently the CI is broken because this pipeline was also dependent on altool, so an upgrade to notarytool is needed.

@dylanhand
Copy link
Contributor

dylanhand commented May 8, 2024

Builder fixed. The build script has been updated to use notarytool and there is a new nightly build available (download link).

The above mentioned Hang Risk fix did not fix the hanging issue.

Using both the latest stable version of Divvun Manager, and the new nightly build I still get the following:

  • Sometimes it loads as expected
  • Sometimes it hangs forever
  • Occasionally it shows a blank screen with no spinner

This is after repeatedly quitting and re-opening the app. It seems like it could be a race condition.

Here's an example of what I see repeatedly quitting and reopening the app:
Divvun Manager Nightly

In one case I also got this error:
CleanShot 2024-05-08 at 13 57 57@2x

@snomos
Copy link
Member Author

snomos commented May 8, 2024

Good that the build is working again. The only thing I can suggest right now is to add more aggressive logging, to possibly identify places where race conditions could occur. Could Sentry logging be of any help?

@dylanhand
Copy link
Contributor

That's what I'll be looking into next. The frustrating part is that the hang never occurs when running from Xcode - it seems to only happen in a production build. So you're right that logging will be the way to go.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants