Skip to content

Drop python 3.8 support. #130

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
bckohan opened this issue Oct 10, 2024 · 0 comments
Closed

Drop python 3.8 support. #130

bckohan opened this issue Oct 10, 2024 · 0 comments
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@bckohan
Copy link
Member

bckohan commented Oct 10, 2024

Python 3.8 security support just ended with the release of 3.13 on 10/7/2024. Normally if there wasn't a compelling reason to drop support I wouldnt so soon, but dropping 3.8 will do two things:

  • Eliminate all of the imports of Annotated from typing_extensions as Annotated was added to stdlib in 3.9
  • Fix the cls parameter overload issue. Typer unwisely used cls as the argument name when overriding the click.Group class to use for commands. This causes issues with how 3.8 passes arguments in meta classes and type constructors, leading to weirdness. This may also make Overriding the command group class does not work. #128 easier to fix.
@bckohan bckohan self-assigned this Oct 10, 2024
@bckohan bckohan added the dependencies Pull requests that update a dependency file label Oct 10, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant