Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add pub fn id() to Account #68

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Add pub fn id() to Account #68

merged 1 commit into from
Oct 23, 2024

Conversation

kvinwang
Copy link
Contributor

This PR adds pub fn id() to Account. The account id is used when we need to add the account to CAA records.

djc
djc approved these changes Oct 23, 2024
View reviewed changes
Copy link
Owner

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like a release for this? If so, please submit a PR with a semver-compatible version bump.

@kvinwang
Copy link
Contributor Author

Would you like a release for this? If so, please submit a PR with a semver-compatible version bump.

I would appreciate having a release. However, I've noticed the version has already been incremented to 0.7.2 which hasn't been published yet. It would be preferable if you manage the version numbering.

@djc djc merged commit 5656412 into djc:main Oct 23, 2024
8 checks passed
@djc
Copy link
Owner

djc commented Oct 24, 2024

  • Published instant-acme v0.7.2 at registry crates-io
  • [new tag] 0.7.2 -> 0.7.2
  • Release notes

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kvinwang @djc