-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support JAXB2.1 #15
Comments
I would be interested in seeing the changes you suggest. Could you fork sources and commit to GitHub? If the changes make sense, I will apply to this project. Project compiles and runs against 2.2.4, I doubt that there is a big community that still uses 2.1.x. |
I forked the repository and committed changes. It works only with JAXB2.1 so it would be better to create a branch. I agree with you not many developers will be interested in JAXB2.1. I have to use it with legacy code. |
Before you have committed you have changed the code formatting, now I see that all files are deleted and added again (link). I would love to see the changes, but I simply can't. Formatting rules are listed on project front page. Do Unit tests pass after your changes? |
Yes, I changed the code formatting as not intended to share it at the beginning. Unit tests are passed. But I had to remove almost all ObjectFactory.java, jaxb doesn't keep method's order. |
What IDE are you using? I can ask around – maybe someone can help me to create compatible formatting rules for your IDE. I doubt that your IDE will show a better diff (as git is changeset-based system) unless IDE is "too smart" and utilizes internal diff comparison (not using |
Closing the issue, as there is no plan to support legacy JAXB 2.1. |
I made changes to this plugin and now it works with jaxb2.1.
I want to send you changes but I can't find your email.
The text was updated successfully, but these errors were encountered: