Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove socket.io dependency #13

Open
randomailer opened this issue May 31, 2018 · 3 comments
Open

Remove socket.io dependency #13

randomailer opened this issue May 31, 2018 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@randomailer
Copy link

You don't need to use socket.io in 2k17

@dmitry-korolev
Copy link
Owner

Pull requests are highly welcomed!

@dmitry-korolev dmitry-korolev added enhancement New feature or request good first issue Good for newcomers labels May 31, 2018
@dmitry-korolev dmitry-korolev changed the title Remove socket.io Remove socket.io dependency May 31, 2018
@mh166
Copy link

mh166 commented Jul 18, 2018

Hi, any hints on how to start about that one?

Where should one begin to dig, where are the dependencies located? Is there anything special to consider when bringing the new solution in place?

Thos would be helpful for getting started. :)

@dmitry-korolev
Copy link
Owner

dmitry-korolev commented Jul 18, 2018

Hi, @mh166
Glad to see you here!

Actually, I've discovered that the internet in general and WebSocket in particular, are not reliable. On my last talk a few days ago I've experienced some issues with low ping and low internet connection speed. Control panel still worked, but it felt uncomfortable.

So, right now I try to find other ways to connect the control panel to the presentation, and audio transport seems very promising to me (see #24) since it will make the server completely unnecessary.

Still, if you want to practice native WebSocket browser API, there is something you can do here.

I think it's not necessary to remove socket.io completely, at least on the server-side. But on the client-side, why not.

Socket.io is used both in the control panel and in the reveal.js plugin, and, I believe, can be replaced entirely with new WebSocket :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants