Test rucio PR 7199 (reaper improvements)

[haozturk]

Enhancement Description

PR to test: https://github.com/rucio/rucio/pull/7199/files

Use Case

Reducing deletion-not-found errors here https://monit-grafana.cern.ch/d/YXu9ENqnz/rucio-file-deletions?orgId=11&from=now-7d&to=now&var-Binning=1d&var-groupby=protocol&var-RSE=All&var-protocol=All&var-scope=All&var-event_type=All&viewPanel=24

Possible Solution

Patch the PR to prod and see if errors will reduce or not. I've just tried to patch it to the rucio version we're currently using (35.4.0) [1,2] and the patching step failed:

Patches found. Trying to apply them
Applying patch /patch/1.patch
patching file transfertool/fts3.py
Patch /patch/1.patch/lib applied.
Applying patch /patch/7106.patch
patching file rucio-replica-recoverer
Patch /patch/7106.patch/bin applied.
Applying patch /patch/7170.patch
patching file core/replica.py
Patch /patch/7170.patch/lib applied.
Applying patch /patch/7199.patch
patching file core/replica.py
Hunk #1 succeeded at 358 (offset -44 lines).
Hunk #2 succeeded at 2368 (offset -172 lines).
Hunk #3 succeeded at 2977 with fuzz 2 (offset -218 lines).
Hunk #4 succeeded at 4180 (offset -316 lines).
patching file daemons/reaper/reaper.py
Hunk #1 succeeded at 43 (offset -2 lines).
Hunk #2 succeeded at 139 (offset -2 lines).
Hunk #3 succeeded at 220 (offset -2 lines).
Hunk #4 succeeded at 467 (offset -2 lines).
Hunk #5 succeeded at 652 (offset -2 lines).
Hunk #6 succeeded at 669 (offset -2 lines).
Patch /patch/7199.patch/lib applied.
Applying patch /patch/token.patch
patching file core/oidc.py
patching file core/rse.py
patching file daemons/reaper/reaper.py
Hunk #1 FAILED at 44.
Hunk #2 succeeded at 642 (offset 25 lines).
1 out of 2 hunks FAILED -- saving rejects to file daemons/reaper/reaper.py.rej
patching file transfertool/fts3.py
Patch /patch/token.patch/lib could not be applied successfully (exit code 1). Exiting setup.

Seems like it conflicts with the token patch that @dynamic-entropy did. This is a problem that we'll face during the upgrade to rucio 36. @dynamic-entropy what's the plan with the token patch? I understand this is to apply directory scoped tokens, however we cannot keep leaving with this patch.

I reverted the changes I've made.

@ericvaandering @labkode FYI

[1] #870
[2] dmwm/rucio-flux#358

Related Issues

No response