Skip to content

Whitelist a small number of env variables used to seed essential node data (new in RabbitMQ 3.9.4) #513

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
michaelklishin opened this issue Aug 11, 2021 · 1 comment · Fixed by #519

Comments

@michaelklishin
Copy link
Collaborator

In #508, RabbitMQ maintainers agreed to support a small number of environment variables that would make node seeding convenient in certain environments (such as ECS or service containers used by GitHub, GitLab and so on). This should ship in 3.9.4 rabbitmq/rabbitmq-server#3299.

However, since the entrypoint of this image now (#467) black lists most previously supported env variables. We should whitelist
the four agreed on in #508 so that they are allowed and propagated to RabbitMQ nodes.

That should make it easier to use this image in more environments without introducing any entrypoint complexity (or undoing any important changes from #467).

@tianon @yosifkit does this sound reasonable to you?

@michaelklishin michaelklishin changed the title Whitelist a small number of env variables used to seed RabbitMQ nodes Whitelist a small number of env variables used to seed essential node data (new in RabbitMQ 3.9.4) Aug 11, 2021
@tianon
Copy link
Member

tianon commented Aug 11, 2021

We're happy with whatever y'all want to support -- unblacklisting those four should just be a matter of removing them from the entrypoint's array. 😄 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants