Condense output of compose top
#12391
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a first draft. The tests could be a bit more exhaustive (i.e. mocking Looking at the test cases now, I also think it should ensure to reorder the CMD column to the end. |
dmke
force-pushed
the
12381-compact-top
branch
from
f26757a to
8a28bee
Compare
dmke
force-pushed
the
12381-compact-top
branch
from
8a28bee to
19dd355
Compare
ndeloof
reviewed
Dec 17, 2024
dmke
force-pushed
the
12381-compact-top
branch
from
b0c36fb to
9b0c720
Compare
This changes the output format of `compose top` and inlines the service container name into the table. Previously, `compose top` had printed something like: <service name> UID PID ... root 1 ... Now, the output looks more like this: SERVICE UID PID ... <name> root 1 ... Signed-off-by: Dominik Menke <dom@digineo.de>
Signed-off-by: Dominik Menke <dom@digineo.de>
Signed-off-by: Dominik Menke <dom@digineo.de>
Signed-off-by: Dominik Menke <dom@digineo.de>
dmke
force-pushed
the
12381-compact-top
branch
from
9b0c720 to
489d8b8
Compare
|
I've also taken the opportunity to:
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This changes the output format of
compose topand inlines the service container name into the table.Previously,
compose tophad printed something like:Now, the output looks more like this:
Related issue
Closes #12381
Baby mountain goat on rock, CC-by-sa Shaundd, WP:Commons