[1.13.x] bump RunC / libcontainer to fix SELinux regression #30649
+12
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
impact/changelog
status/2-code-review
and removed
status/0-triage
labels
tonistiigi
reviewed
Feb 1, 2017
hack/dockerfile/binaries-commits
Outdated
| @@ -1,7 +1,9 @@ | |||
| #!/bin/sh | |||
|
|
|||
| TOMLV_COMMIT=9baf8a8a9f2ed20a8e54160840c492f937eeaf9a | |||
| RUNC_COMMIT=2f7393a47307a16f8cee44a37b262e8b81021e3e | |||
|
|
|||
| # When updating RUNC_COMMIT, also update libcontainerd in vendor.conf accordingly | |||
There was a problem hiding this comment.
ah, was doubting, because that line especially refers to libcontainer; will update, hold on
This bumps RunC and libcontainer to fix a regression in 1.13 that caused SELinux labels to not be applied correctly. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
1.13-bump-runc
branch
from
d5cad2b to
d00e249
Compare
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
|
I'll look at a similar PR for master |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps RunC and libcontainer to fix a regression
in 1.13 that caused SELinux labels to not be
applied correctly.
diff is http://github.com/docker/runc/compare/2f7393a47307a16f8cee44a37b262e8b81021e3e...9df8b306d01f59d3a8029be411de015b7304dd8f
For more information about this change, see the discussion on opencontainers/runc#1303, #30532 (comment), and opencontainers/runc#1109 (comment)
ping @cpuguy83 @runcom @rhatdan PTAL