-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
overlay2: fix unmounting layer without merge dir #31069
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
4fb74d5
to
e1af6c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok but why wouldn't there be a merge dir?
@@ -30,7 +30,7 @@ import ( | |||
"github.com/docker/docker/pkg/mount" | |||
"github.com/docker/docker/pkg/parsers" | |||
"github.com/docker/docker/pkg/parsers/kernel" | |||
"github.com/docker/go-units" | |||
units "github.com/docker/go-units" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it's not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do like that though 👼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of those situations where I would have thought this was already done
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐸
@@ -30,7 +30,7 @@ import ( | |||
"github.com/docker/docker/pkg/mount" | |||
"github.com/docker/docker/pkg/parsers" | |||
"github.com/docker/docker/pkg/parsers/kernel" | |||
"github.com/docker/go-units" | |||
units "github.com/docker/go-units" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do like that though 👼
cherry-picked into 17.03.1 through #31754 |
cherry-pick from: moby#31069 Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> Signed-off-by: Lei Jitang <leijitang@huawei.com> (cherry picked from commit e1af6c8)
@dmcgowan
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com