Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

builder: Fix setting command with custom shell #32236

Merged
merged 1 commit into from
Mar 31, 2017
Merged

builder: Fix setting command with custom shell #32236

merged 1 commit into from
Mar 31, 2017

Conversation

tonistiigi
Copy link
Member

@tonistiigi tonistiigi commented Mar 30, 2017 •
edited by thaJeztah
Loading

getShell returned a static array that is appended multiple times. Second append overrides the values for the previous one.

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

@tonistiigi
builder: Fix setting command with custom shell
a1fa59e 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi tonistiigi requested a review from thaJeztah March 30, 2017 20:32
vdemeester
vdemeester approved these changes Mar 30, 2017
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦁

thaJeztah
thaJeztah approved these changes Mar 30, 2017
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 05cd8be into moby:master Mar 31, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.05.0 milestone Mar 31, 2017
@thaJeztah thaJeztah added area/builder area/builder/classic-builder Issues affecting the classic builder labels Aug 30, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
area/builder/classic-builder Issues affecting the classic builder area/builder impact/changelog impact/dockerfile status/2-code-review
Projects
None yet
Milestone
17.05.0
4 participants
@tonistiigi @vdemeester @thaJeztah @GordonTheTurtle