Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update expiry of fixture certs to at least 2 years in the future #951

Merged
merged 2 commits into from
Sep 12, 2016
Merged

Update expiry of fixture certs to at least 2 years in the future #951

merged 2 commits into from
Sep 12, 2016

Conversation

cyli
Copy link
Contributor

@cyli cyli commented Sep 12, 2016

Signed-off-by: Ying Li ying.li@docker.com

@cyli cyli added this to the Notary 0.4 milestone Sep 12, 2016
@riyazdf
Copy link
Contributor

riyazdf commented Sep 12, 2016

LGTM on green!

cyli added 2 commits September 12, 2016 14:07
@cyli
Update expiry of fixture certs to at least 2 years in the future. Also,
b8fc638 
regenerate self-signed_docker.com-notary.crt and self-signed_secure.example.com.

Signed-off-by: Ying Li <ying.li@docker.com>
@cyli
Update cert pinning code with a little more debugging
6976e9c 
Signed-off-by: Ying Li <ying.li@docker.com>
@cyli cyli force-pushed the update-cert-expiry branch from 2590d9f to 6976e9c Compare September 12, 2016 21:07
@cyli
Copy link
Contributor Author

cyli commented Sep 12, 2016

Updated this to do another 3 things:

  1. use a sha256 signing algorithm instead of whatever is default (which may be SHA1 on older versions of openssl, which we reject)
  2. use a different CN for the intermediate cert so we can more easily tell what signed what
  3. also generate 2 other certs that are in the fixtures library

@riyazdf
Copy link
Contributor

riyazdf commented Sep 12, 2016

thanks for the updates! LGTM pending CI :)

@endophage
Copy link
Contributor

LGTM

@endophage endophage merged commit 1285ab0 into notaryproject:release/0.4.0 Sep 12, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status/0-triage
Projects
None yet
Milestone
Notary 0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@cyli @riyazdf @endophage @GordonTheTurtle